Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark PoV Size to avoid bricking the chain with custom consensus #527

Open
Garandor opened this issue May 3, 2022 · 0 comments
Open

Benchmark PoV Size to avoid bricking the chain with custom consensus #527

Garandor opened this issue May 3, 2022 · 0 comments
Labels
A-ci Area: Continuous Integration A-consensus Area: Issues and PRs related to Consensus A-runtime Area: Issues and PRs related to Runtimes A-testing Area: Testing-related Issues and PRs C-enhancement Category: An issue proposing an enhancement or a PR with one P-medium Priority: Medium
Milestone
Blocked-By-External

Comments

@Garandor
Copy link
Contributor

Garandor commented May 3, 2022 •
edited
Loading

Companion to and blocked by: paritytech/polkadot-sdk#398
Related to paritytech/substrate#387

Once we start modifying consensus inherents, it's possible to overflow the allowed 5MB PoV size with heavy on_initialize/on_finalize hooks and brick the chain.
We need to add PoV benchmarking once parity ships it to have an insight on PoV heaviness and prevent that from happening
@Garandor Garandor added C-enhancement Category: An issue proposing an enhancement or a PR with one A-runtime Area: Issues and PRs related to Runtimes A-consensus Area: Issues and PRs related to Consensus labels May 3, 2022
@Garandor Garandor added this to the Blocked-By-External milestone Jun 12, 2022
@ghzlatarev ghzlatarev added the P-medium Priority: Medium label Jul 15, 2022
@ghzlatarev ghzlatarev added A-ci Area: Continuous Integration A-testing Area: Testing-related Issues and PRs labels Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ci Area: Continuous Integration A-consensus Area: Issues and PRs related to Consensus A-runtime Area: Issues and PRs related to Runtimes A-testing Area: Testing-related Issues and PRs C-enhancement Category: An issue proposing an enhancement or a PR with one P-medium Priority: Medium
Projects
None yet
Milestone
Blocked-By-External
Development

No branches or pull requests
2 participants
@Garandor @ghzlatarev