Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.7 support? #1148

Closed
ml-evs opened this issue May 8, 2022 · 4 comments · Fixed by #1179
Closed

Drop Python 3.7 support? #1148

ml-evs opened this issue May 8, 2022 · 4 comments · Fixed by #1179
Labels
needs discussion priority/medium Issue or PR with a consensus of medium priority question Further information is requested

Comments

@ml-evs
Copy link
Member

ml-evs commented May 8, 2022

Several packages we depend on are dropping Python 3.7 support, driven I guess by NumPy's deprecation timeline: https://numpy.org/neps/nep-0029-deprecation_policy.html

Dependabot does not show us updates that use incompatible Python versions, so we might have to just follow the crowd here and drop 3.7 support sooner rather than later ourselves too.

@ml-evs ml-evs added question Further information is requested priority/medium Issue or PR with a consensus of medium priority needs discussion labels May 8, 2022
@ml-evs
Copy link
Member Author

ml-evs commented May 8, 2022

I'm not actually sure how dependabot interacts with different Python versions. It might be grabbing Python 3.7 from our unloved Pipfile:

python_version = "3.7"

I would suggest we drop the Pipfile if no-one we know is using it.

@ml-evs ml-evs mentioned this issue May 8, 2022
@JPBergsma
Copy link
Contributor

I think It would be best to ask the users whether they would have a problem if we dropped support for python 3.7.
Perhaps we could do this at the upcoming Optimade meeting.
It would also be nice if we could somehow give a deprecation warning that a future version of optimade will no longer support python 3.8. This should give users some time to switch to a newer version of python.

I am currently still using python 3.7 in my optimade environment. But I do not think it should be a problem to upgrade to 3.8

@ml-evs
Copy link
Member Author

ml-evs commented May 9, 2022

Good plan, I think we should add a deprecation warning now before we release 0.17, as we will probably want to drop support entirely by the time 0.18 comes around.

@JPBergsma
Copy link
Contributor

That sounds good, issue the deprecation warning in version 0.17 and then drop support for python 3.7 in version 0.18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs discussion priority/medium Issue or PR with a consensus of medium priority question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants