Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to specification v0.10.1-develop #115

Closed
8 of 9 tasks
CasperWA opened this issue Jan 6, 2020 · 3 comments
Closed
8 of 9 tasks

Minor changes to specification v0.10.1-develop #115

CasperWA opened this issue Jan 6, 2020 · 3 comments
Labels
grammar Concerns the Lark grammar files help wanted Extra attention is needed priority/high Issue or PR with a consensus of high priority schema Concerns the schema models

Comments

@CasperWA
Copy link
Member

CasperWA commented Jan 6, 2020

There are currently minor changes to the specification of v0.10.1-develop.
More may come and should be added below.

Schema / Models

Grammar

Miscellaneous

@CasperWA CasperWA added the schema Concerns the schema models label Jan 6, 2020
@CasperWA CasperWA added this to the OPTiMaDe v0.10.1 milestone Jan 6, 2020
@CasperWA CasperWA added grammar Concerns the Lark grammar files help wanted Extra attention is needed labels Jan 6, 2020
@ml-evs
Copy link
Member

ml-evs commented Jan 9, 2020

Any of these in progress atm? I'm happy to take the model updates (excl #114) and have a go at a landing page when I get a chance later.

@ml-evs
Copy link
Member

ml-evs commented Jan 9, 2020

Just knocked off a few of these in #126, but I'm confused about this homepage stuff.

We already have the homepage attribute in our Provider model, but not in Links (which has its own subtype called Provider)... simply adding it to the model and updating the index_links.json and test_links.json causes a lot of errors for me, which I don't have time to look at right now. I'll open the PR and leave it hanging.

@CasperWA CasperWA pinned this issue Jan 9, 2020
@CasperWA CasperWA added the priority/high Issue or PR with a consensus of high priority label Feb 5, 2020
@CasperWA
Copy link
Member Author

CasperWA commented Feb 6, 2020

Closing this and adding an issue specifically for the remaining OPTIONAL task.

@CasperWA CasperWA closed this as completed Feb 6, 2020
@CasperWA CasperWA unpinned this issue Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grammar Concerns the Lark grammar files help wanted Extra attention is needed priority/high Issue or PR with a consensus of high priority schema Concerns the schema models
Projects
None yet
Development

No branches or pull requests

2 participants