Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The invoke task update-openapijson is incomplete #123

Closed
CasperWA opened this issue Jan 9, 2020 · 0 comments · Fixed by #124
Closed

The invoke task update-openapijson is incomplete #123

CasperWA opened this issue Jan 9, 2020 · 0 comments · Fixed by #124
Assignees
Labels
bug Something isn't working

Comments

@CasperWA
Copy link
Member

CasperWA commented Jan 9, 2020

The invoke task update-openapijson only copies over the local openapi JSON files, but does not update them before-hand, i.e., if you are developing and switching between branches, you will mix up your openapi JSON files from different branches (since the local openapi JSON files are not tracked via git).

This can be remedied quite simply by updating the local openapi JSON files prior to copying them.

Note: I believe this is what has caused the failling jsondiff pre-commit as well, since this may not always run locally, I guess?

@CasperWA CasperWA added the bug Something isn't working label Jan 9, 2020
@CasperWA CasperWA self-assigned this Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant