-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
None
values in lattice_vectors
#170
Comments
Relevant part of the spec:
Which part indicates that they all have to be |
This part:
But I am still not sure this always falls out to be a complete lattice vector? Concerning the determinant, we can validate that as well if you want? It would probably make sense, but since it is SHOULD, it also isn't REQUIRED, so it shouldn't raise if not true, but instead maybe return a |
It's not clear to me that the sentence is stipulating that all values must be I don't have strong feelings about the determinant. We could validate it in the case of |
I agree with @ml-evs that it doesn't imply that it has to be
|
It seems from the definition of
lattice_vectors
that while the values may beNone
, they should be it for a vector as a whole.This should be checked in the models by a
pydantic
validator.The text was updated successfully, but these errors were encountered: