Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'minor' and 'patch' versioned base URL prefixes are wrong #177

Closed
CasperWA opened this issue Feb 13, 2020 · 0 comments · Fixed by #178
Closed

'minor' and 'patch' versioned base URL prefixes are wrong #177

CasperWA opened this issue Feb 13, 2020 · 0 comments · Fixed by #178
Assignees
@CasperWA
Labels
bug Something isn't working priority/high Issue or PR with a consensus of high priority

Comments

@CasperWA
Copy link
Member

The versioned base URLs only take out the specific version number part and add after /optimade/v.
It should instead add major and minor version together for the 'minor' prefix and be the full version number for the 'patch' prefix.
@CasperWA CasperWA added bug Something isn't working priority/high Issue or PR with a consensus of high priority labels Feb 13, 2020
@CasperWA CasperWA self-assigned this Feb 13, 2020
@CasperWA CasperWA mentioned this issue Feb 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CasperWA CasperWA

Labels
bug Something isn't working priority/high Issue or PR with a consensus of high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correctly create optional versioned base URLs Materials-Consortia/optimade-python-tools
1 participant
@CasperWA