Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relationships don't work when "/" present in id #181

Closed
ml-evs opened this issue Feb 15, 2020 · 0 comments · Fixed by #183
Closed

Relationships don't work when "/" present in id #181

ml-evs opened this issue Feb 15, 2020 · 0 comments · Fixed by #183
Assignees
@ml-evs
Labels
bug Something isn't working parser Related to the Lark parser priority/high Issue or PR with a consensus of high priority

Comments

@ml-evs
Copy link
Member

ml-evs commented Feb 15, 2020 •
edited
Loading

Just ran into this: if you have e.g. a reference that has id dummy/2019, all requests that return a structure with a relationship with this reference will fall over with lark errors.
@ml-evs ml-evs self-assigned this Feb 15, 2020
@CasperWA CasperWA added bug Something isn't working parser Related to the Lark parser labels Feb 17, 2020
@ml-evs ml-evs mentioned this issue Feb 18, 2020
Merged
@CasperWA CasperWA added the priority/high Issue or PR with a consensus of high priority label Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ml-evs ml-evs

Labels
bug Something isn't working parser Related to the Lark parser priority/high Issue or PR with a consensus of high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix errors parsing IDs that contain slashes Materials-Consortia/optimade-python-tools
2 participants
@ml-evs @CasperWA