Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling of KNOWN in mongo backend #254

Closed
ml-evs opened this issue Apr 24, 2020 · 0 comments · Fixed by #279
Closed

Handling of KNOWN in mongo backend #254

ml-evs opened this issue Apr 24, 2020 · 0 comments · Fixed by #279
Assignees
@ml-evs
Labels
priority/medium Issue or PR with a consensus of medium priority transformer/MongoDB Related to filter transformer for MongoDB

Comments

@ml-evs
Copy link
Member

ml-evs commented Apr 24, 2020

Looks like we transform property IS KNOWN into the Mongo "property": {"$exists": True} where according to the spec we should also check if its null:

https://github.com/Materials-Consortia/OPTiMaDe/blob/develop/optimade.rst#36properties-with-an-unknown-value
@ml-evs ml-evs added priority/medium Issue or PR with a consensus of medium priority transformer/MongoDB Related to filter transformer for MongoDB labels Apr 24, 2020
@ml-evs ml-evs self-assigned this May 26, 2020
@ml-evs ml-evs mentioned this issue May 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ml-evs ml-evs

Labels
priority/medium Issue or PR with a consensus of medium priority transformer/MongoDB Related to filter transformer for MongoDB
Projects
None yet
Milestone
No milestone
1 participant
@ml-evs