Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple updates in providers repo #311

Closed
shyamd opened this issue Jun 11, 2020 · 1 comment · Fixed by #312
Closed

Decouple updates in providers repo #311

shyamd opened this issue Jun 11, 2020 · 1 comment · Fixed by #312
Assignees
@shyamd
Labels
dependency_updates Issues pertaining to updates to our dependencies that are breaking the eager build priority/medium Issue or PR with a consensus of medium priority schema Concerns the schema models

Comments

@shyamd
Copy link
Contributor

shyamd commented Jun 11, 2020

Due to the need of #306 and the circular dependency it highlights, we need to decouple at minimum providers, but also any other repos. Rather the connection should be via "versions" of some sort plus dependabot or some other CI making a PR with the new version that gets tested. This will ensure we know when things are breaking.
@shyamd shyamd self-assigned this Jun 11, 2020
@CasperWA
Copy link
Member

Ah, now I see what you mean with "version" :)

@shyamd shyamd mentioned this issue Jun 11, 2020
Merged
@CasperWA CasperWA added dependency_updates Issues pertaining to updates to our dependencies that are breaking the eager build priority/medium Issue or PR with a consensus of medium priority schema Concerns the schema models labels Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shyamd shyamd

Labels
dependency_updates Issues pertaining to updates to our dependencies that are breaking the eager build priority/medium Issue or PR with a consensus of medium priority schema Concerns the schema models
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Decouple changes in providers repo
2 participants
@shyamd @CasperWA