-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Un)versioned URLs #379
Comments
In fact, its just been merged, so we better get a move on! |
Will you actually handle Edit: Ah, sorry, I was thinking for the schemas. But of course the implementation needs to provide the endpoint! |
I've implemented it in #380 in such a way that it does not appear in the schema; I think there is some argument to made that the versions endpoint should appear in the schema, but I'm not sure of the appropriate way to represent it... |
Has this been closed by #380 or are there still things to double check? |
Closed by #380. |
We should start tracking Materials-Consortia/OPTIMADE#290 and discuss how we want to deal with it in the server code.
The PR will introduce the following:
/versions
endpointAt the very least, this is going to change how the validator needs to work. If given an unversioned base url, the validator needs to check for a
/versions
endpoint, so we probably need to add a flag to allow for versioned URLs to be tested without having to provide the/versions
endpoint.The text was updated successfully, but these errors were encountered: