setuptools package with server as "extra"

[markus1978]

Great work on the optimade tools.

Unfortunately, the server implementation brings a lot of dependencies (including Python 3.7?). This way, I cannot use the package out of the box (i.e. git repo) and have to either clone/copy code, or modify the setup, etc.

Would be great, if this had more flexibility and we could use an additional "extra" (similar to dev, e.g. pip install optimade[server]) to make it more modular.

If you agree, I could try to find the time and prepare pull request: #63

[dwinston]

I like the “extras” decomposition idea very much. I imagine it may be hard to extricate the server using this technique, though, as I’m not sure one can specify a different version of Python in the “extras”; I could be wrong. It may be necessary to specify a separate pip package optimade-server that nevertheless can have its code in this repo?

I definitely think that the Django tooling (from #61) would be a perfect candidate for extraction as an “extra”, so that folks needn’t have to install Django unless they use the Django tooling.

[markus1978]

I am more worried about the dependencies than the python version. I can simply ignore the latter using --ignore-requires-python on pip install.

Having all the transformers for various platforms is great. But it makes it harder to maintain. For example, I did not found a 0.10.0 grammar and started to use my own. But I'll can never test and then pull request it, if I do not also adapt all the transformers.

[dwinston]

@markus1978 great point about the coupling of grammar PRs to transformer tests. I had not thought of that. I am in favor of decoupling them, e.g. a given contributed transformer can be tested against given grammar versions, and there is no hard requirement for a contributed grammar to have passing tests for any transformers other than the JSONTransformer (trivial) in order to merge a PR. This is particularly valuable for pre-1.0 grammars (0.10.0 seems quite close, but it's not 1.0), as I think we should prioritize getting the 0.10.0 grammar into this repo.

Please feel free to start a WIP PR to add your 0.10.0 and reference my comment here to see if other repo maintainers agree.

[dwinston]

It also seems that the just-merged Django transformer is pinned to the 0.9.7 grammar anyway, so you will encounter no breaking tests in adding a 0.10.0 grammar.

[markus1978]

I'll agree, having transformers pinned to specific grammars will make maintenance easy enough. When I have completed the 0.10.0 grammar (+ elastic search transformer), I open PR. I'll include the necessary setup.py changes for the [server] thing.

[CasperWA]

I think the [server] thing is still relevant from this issue.

[CasperWA]

I now consider this properly closed by PR #88. If new or related issues arise, please create a new GitHub issue.