Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating permanent dependabot branch not working after updating dependencies #995

Closed
CasperWA opened this issue Nov 10, 2021 · 1 comment · Fixed by #996 or #1000
Closed

Updating permanent dependabot branch not working after updating dependencies #995

CasperWA opened this issue Nov 10, 2021 · 1 comment · Fixed by #996 or #1000
Assignees
@CasperWA
Labels
bug Something isn't working CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action) dependency_updates Issues pertaining to updates to our dependencies that are breaking the eager build

Comments

@CasperWA
Copy link
Member

Because the logic to check whether the dependencies have just been updated is comparing the PR body text, this step fails - essentially because the static PR body text have the checkboxes unchecked.
This can be fixed by ignoring the checkbox lines or taking into account that instead of [ ] it can be [X] or [x].
@CasperWA CasperWA added bug Something isn't working dependency_updates Issues pertaining to updates to our dependencies that are breaking the eager build CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action) labels Nov 10, 2021
@CasperWA CasperWA self-assigned this Nov 10, 2021
@CasperWA CasperWA mentioned this issue Nov 10, 2021
Merged
@CasperWA
Copy link
Member Author

This issue persists, see this job run.

A viable solution might be to use diff instead, employing the --strip-trailing-cr option. At least this seems to work for me locally.

@CasperWA CasperWA reopened this Nov 17, 2021
@CasperWA CasperWA mentioned this issue Nov 17, 2021
Merged
@CasperWA CasperWA mentioned this issue Dec 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CasperWA CasperWA

Labels
bug Something isn't working CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action) dependency_updates Issues pertaining to updates to our dependencies that are breaking the eager build
Projects
None yet
Milestone
No milestone
1 participant
@CasperWA