Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable validation of unversioned paths #52

Closed
ml-evs opened this issue Jan 7, 2021 · 1 comment · Fixed by #53
Closed

Option to disable validation of unversioned paths #52

ml-evs opened this issue Jan 7, 2021 · 1 comment · Fixed by #53
Assignees
Labels
bug Something isn't working

Comments

@ml-evs
Copy link
Member

ml-evs commented Jan 7, 2021

There is currently no option for disabling validation of the unversioned base URL, effectively making it mandatory. While validation of this URL can be useful (and is required to check for things like the versions endpoint) the optimade-validator itself still expects to find a full implementation at the unversioned URL, if that is what is passed to it.

Unless/until we change the validator to do the version negotiation for us (Materials-Consortia/optimade-python-tools#662) it would be helpful to have a setting that validates just the URL passed through GitHub actions.

@ml-evs
Copy link
Member Author

ml-evs commented Jan 7, 2021

Unless/until we change the validator to do the version negotiation for us (Materials-Consortia/optimade-python-tools#662) it would be helpful to have a setting that validates just the URL passed through GitHub actions.

Alternative framing: option to disable unversioned URL validation (perhaps even by default) so that only <base_url>/v1 gets validated by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant