You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the test of as type, it seems we're passing the root base URL, which shouldn't be the case, right? We should pass in a full URL to a relevant single endpoint that should be validated using the passed type?
In the test of
as type
, it seems we're passing the root base URL, which shouldn't be the case, right? We should pass in a full URL to a relevant single endpoint that should be validated using the passed type?I.e., instead of testing:
TEST_BASE_RUN_VALIDATOR="optimade-validator $( for i in {1..${INPUT_VERBOSITY}}; do echo '-v '; done; )--as-type ${VALID_AS_TYPE_VALUE} ${INPUT_PROTOCOL}://${INPUT_DOMAIN}${INPUT_PATH}"
We should be testing:
TEST_BASE_RUN_VALIDATOR="optimade-validator $( for i in {1..${INPUT_VERBOSITY}}; do echo '-v '; done; )--as-type ${VALID_AS_TYPE_VALUE} ${INPUT_PROTOCOL}://${INPUT_DOMAIN}${INPUT_PATH}v1/structures/${VALID_STRUCTURE_ID}"
Where
VALID_STRUCTURE_ID
is a variable that ensures we are testing a valid structure ID.Note,
VALID_AS_TYPE_VALUE=structure
here.Essentially, the action should avoid adding versioned parts to the URL and simply use the passed
path
parameter as is.The text was updated successfully, but these errors were encountered: