From 3193495c5c9904b8f436e1ee5fe8f7133cffdea7 Mon Sep 17 00:00:00 2001
From: Matthias Beerens <3512339+Matthiee@users.noreply.github.com>
Date: Sun, 10 Jul 2022 07:41:48 +0200
Subject: [PATCH] Use MinVer for Nuget Package versioning (#44)

* Add MinVer

* Use MinVer to generate correct package versions fixes #42

* Bump fetch v3

* Use correct symbol
---
 .github/workflows/dotnet.yml                  |  4 +-
 .../FinancialModelingPrepApi.csproj           | 88 ++++++++++---------
 .../FinancialModelingPrepApi.xml              | 10 +++
 .../CompanyValuation/CompanyValuationTests.cs |  2 +-
 4 files changed, 62 insertions(+), 42 deletions(-)

diff --git a/.github/workflows/dotnet.yml b/.github/workflows/dotnet.yml
index 75e80fe..52b5afc 100644
--- a/.github/workflows/dotnet.yml
+++ b/.github/workflows/dotnet.yml
@@ -12,7 +12,9 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
+      with: 
+        fetch-depth: 0
     - name: Setup .NET
       uses: actions/setup-dotnet@v1
       with:
diff --git a/FinancialModelingPrepApi/FinancialModelingPrepApi.csproj b/FinancialModelingPrepApi/FinancialModelingPrepApi.csproj
index 7b3b567..bcea8f6 100644
--- a/FinancialModelingPrepApi/FinancialModelingPrepApi.csproj
+++ b/FinancialModelingPrepApi/FinancialModelingPrepApi.csproj
@@ -1,46 +1,54 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
-  <PropertyGroup>
-    <TargetFramework>net5.0</TargetFramework>
-    <RootNamespace>MatthiWare.FinancialModelingPrep</RootNamespace>
-    <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
-    <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
-    <AssemblyVersion>0.1.12.0</AssemblyVersion>
-    <FileVersion>0.1.12.0</FileVersion>
-    <Company>MatthiWare</Company>
-    <PackageId>MatthiWare.FinancialModelingPrep</PackageId>
-    <Version>0.1.12</Version>
-    <Description>FinancialModelingPrep API Client written in .NET 5</Description>
-    <Copyright>Copyright Matthias Beerens 2021</Copyright>
-    <Product>FinancialModelingPrep API Client</Product>
-    <Authors>Matthias Beerens</Authors>
-    <PackageLicenseFile>LICENSE</PackageLicenseFile>
-    <RepositoryUrl>https://github.com/MatthiWare/FinancialModelingPrep.NET</RepositoryUrl>
-    <RepositoryType>git</RepositoryType>
-    <PackageTags>FinancialModelingPrep stock quote finance-api</PackageTags>
-    <PackageProjectUrl>https://github.com/MatthiWare/FinancialModelingPrep.NET</PackageProjectUrl>
-    <PackageReleaseNotes>
-		- GetEnterpriseValueAsync Type fixed
-	</PackageReleaseNotes>
-    <AssemblyName>FinancialModelingPrep</AssemblyName>
-  </PropertyGroup>
+	<PropertyGroup>
+		<TargetFramework>net5.0</TargetFramework>
+		<RootNamespace>MatthiWare.FinancialModelingPrep</RootNamespace>
+		<PackageRequireLicenseAcceptance>False</PackageRequireLicenseAcceptance>
+		<GeneratePackageOnBuild>True</GeneratePackageOnBuild>
+		<Company>MatthiWare</Company>
+		<PackageId>MatthiWare.FinancialModelingPrep</PackageId>
+		<Description>FinancialModelingPrep API Client written in .NET 5</Description>
+		<Copyright>Copyright Matthias Beerens 2021</Copyright>
+		<Product>FinancialModelingPrep API Client</Product>
+		<Authors>Matthias Beerens</Authors>
+		<PackageLicenseFile>LICENSE</PackageLicenseFile>
+		<RepositoryUrl>https://github.com/MatthiWare/FinancialModelingPrep.NET</RepositoryUrl>
+		<RepositoryType>git</RepositoryType>
+		<PackageTags>FinancialModelingPrep stock quote finance-api</PackageTags>
+		<PackageProjectUrl>https://github.com/MatthiWare/FinancialModelingPrep.NET</PackageProjectUrl>
+		<PackageReleaseNotes>
+			- GetEnterpriseValueAsync Type fixed
+		</PackageReleaseNotes>
+		<AssemblyName>FinancialModelingPrep</AssemblyName>
+	</PropertyGroup>
 
-  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
-    <DocumentationFile>D:\Source\Repos\FinancialModelingPrep.NET\FinancialModelingPrepApi\FinancialModelingPrepApi.xml</DocumentationFile>
-  </PropertyGroup>
+	<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
+		<DocumentationFile>D:\Source\Repos\FinancialModelingPrep.NET\FinancialModelingPrepApi\FinancialModelingPrepApi.xml</DocumentationFile>
+	</PropertyGroup>
 
-  <ItemGroup>
-    <PackageReference Include="Bert.RateLimiters" Version="1.0.15" />
-    <PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="6.0.0" />
-    <PackageReference Include="Microsoft.Extensions.Http" Version="6.0.0" />
-    <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="6.0.1" />
-  </ItemGroup>
+	<ItemGroup>
+		<PackageReference Include="Bert.RateLimiters" Version="1.0.15" />
+		<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="6.0.0" />
+		<PackageReference Include="Microsoft.Extensions.Http" Version="6.0.0" />
+		<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="6.0.1" />
+		<PackageReference Include="MinVer" Version="4.1.0">
+			<PrivateAssets>all</PrivateAssets>
+			<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+		</PackageReference>
+	</ItemGroup>
 
-  <ItemGroup>
-    <None Include="..\LICENSE">
-      <Pack>True</Pack>
-      <PackagePath></PackagePath>
-    </None>
-  </ItemGroup>
+	<PropertyGroup>
+		<MinVerSkip Condition="'$(Configuration)|$(Platform)'=='Debug'">true</MinVerSkip>
+		<MinVerTagPrefix>v</MinVerTagPrefix>
+		<MinVerIgnoreHeight>true</MinVerIgnoreHeight>
+		<MinVerVerbosity>normal</MinVerVerbosity>
+	</PropertyGroup>
+
+	<ItemGroup>
+		<None Include="..\LICENSE">
+			<Pack>True</Pack>
+			<PackagePath></PackagePath>
+		</None>
+	</ItemGroup>
 
 </Project>
diff --git a/FinancialModelingPrepApi/FinancialModelingPrepApi.xml b/FinancialModelingPrepApi/FinancialModelingPrepApi.xml
index 46820a1..84ebc22 100644
--- a/FinancialModelingPrepApi/FinancialModelingPrepApi.xml
+++ b/FinancialModelingPrepApi/FinancialModelingPrepApi.xml
@@ -62,6 +62,13 @@
             <param name="to">To date YYYY-MM-DD</param>
             <returns></returns>
         </member>
+        <member name="M:MatthiWare.FinancialModelingPrep.Abstractions.CompanyValuation.ICompanyValuationProvider.GetSymbolChangesAsync">
+            <summary>
+            Public comapnies sometimes change their symbol and thanks to this endpoint you will be able to know if there is any symbol change happened. 
+            Data for new symbol is getting transferred from the old symbol the same day
+            </summary>
+            <returns></returns>
+        </member>
         <member name="M:MatthiWare.FinancialModelingPrep.Abstractions.InstitutionalFund.IInstitutionalFundProvider.Get13FListAsync">
             <summary>
             Complete list of all institutional investment managers by cik 
@@ -234,6 +241,9 @@
         <member name="M:MatthiWare.FinancialModelingPrep.Core.Calendars.CalendarsProvider.GetStockSplitCalendarAsync(System.String,System.String)">
             <inheritdoc/>
         </member>
+        <member name="M:MatthiWare.FinancialModelingPrep.Core.CompanyValuation.CompanyValuationProvider.GetSymbolChangesAsync">
+            <inheritdoc />
+        </member>
         <member name="T:MatthiWare.FinancialModelingPrep.Core.FinancialModelingPrepApiClient">
             <inheritdoc/>
         </member>
diff --git a/Tests/CompanyValuation/CompanyValuationTests.cs b/Tests/CompanyValuation/CompanyValuationTests.cs
index 468cb89..c747670 100644
--- a/Tests/CompanyValuation/CompanyValuationTests.cs
+++ b/Tests/CompanyValuation/CompanyValuationTests.cs
@@ -302,7 +302,7 @@ public async Task GetCompanyKeyMetricsTTMAsync(string symbol)
         [InlineData("AGS.BR", Period.Annual)]
         [InlineData("CMCSA", Period.Annual)]
         [InlineData("O", Period.Annual)]
-        [InlineData("BRK.B", Period.Annual)]
+        [InlineData("BRK-B", Period.Annual)]
         [InlineData("CX", Period.Annual)]
         public async Task GetCompanyKeyMetricsAsync(string symbol, Period period)
         {