From e4dce8c474868302aa18da8a8e5db407de36ce84 Mon Sep 17 00:00:00 2001 From: Matthias Beerens <3512339+Matthiee@users.noreply.github.com> Date: Mon, 6 Feb 2023 18:26:11 +0100 Subject: [PATCH] Make interest income nullable (#81) * Make interest income nullable * Remove count assert --- .../IncomeStatementResponse.cs | 2 +- .../CompanyValuation/CompanyValuationTests.cs | 21 +++++++++++++------ 2 files changed, 16 insertions(+), 7 deletions(-) diff --git a/FinancialModelingPrepApi/Model/CompanyValuation/IncomeStatementResponse.cs b/FinancialModelingPrepApi/Model/CompanyValuation/IncomeStatementResponse.cs index e14db52..372f249 100644 --- a/FinancialModelingPrepApi/Model/CompanyValuation/IncomeStatementResponse.cs +++ b/FinancialModelingPrepApi/Model/CompanyValuation/IncomeStatementResponse.cs @@ -62,7 +62,7 @@ public class IncomeStatementResponse public double CostAndExpenses { get; set; } [JsonPropertyName("interestIncome")] - public double InterestIncome { get; set; } + public double? InterestIncome { get; set; } [JsonPropertyName("interestExpense")] public double InterestExpense { get; set; } diff --git a/Tests/CompanyValuation/CompanyValuationTests.cs b/Tests/CompanyValuation/CompanyValuationTests.cs index 45402cb..80ee15e 100644 --- a/Tests/CompanyValuation/CompanyValuationTests.cs +++ b/Tests/CompanyValuation/CompanyValuationTests.cs @@ -142,13 +142,14 @@ public async Task GetEnterpriseValue(string symbol) [InlineData("AGS.BR")] [InlineData("PPL.TO")] [InlineData("TSLA")] + [InlineData("AAP")] + [InlineData("MTG")] public async Task GetIncomeStatement(string symbol) { - var result = await api.GetIncomeStatementAsync(symbol, Period.Annual, 5); + var result = await api.GetIncomeStatementAsync(symbol, Period.Annual, 10000); result.AssertNoErrors(); Assert.NotEmpty(result.Data); - Assert.Equal(5, result.Data.Count); Assert.All(result.Data, data => Assert.Equal(symbol, data.Symbol)); } @@ -158,6 +159,8 @@ public async Task GetIncomeStatement(string symbol) [InlineData("AGS.BR")] [InlineData("PPL.TO")] [InlineData("TSLA")] + [InlineData("AAP")] + [InlineData("MTG")] public async Task GetIncomeStatementPerQuarter(string symbol) { var result = await api.GetIncomeStatementAsync(symbol, Period.Quarter, limit: 10000); @@ -173,13 +176,14 @@ public async Task GetIncomeStatementPerQuarter(string symbol) [InlineData("AGS.BR")] [InlineData("PPL.TO")] [InlineData("TSLA")] + [InlineData("AAP")] + [InlineData("MTG")] public async Task GetCashFlowStatement(string symbol) { - var result = await api.GetCashFlowStatementAsync(symbol, Period.Annual, 5); + var result = await api.GetCashFlowStatementAsync(symbol, Period.Annual, 10000); result.AssertNoErrors(); Assert.NotEmpty(result.Data); - Assert.Equal(5, result.Data.Count); Assert.All(result.Data, data => Assert.Equal(symbol, data.Symbol)); } @@ -189,6 +193,8 @@ public async Task GetCashFlowStatement(string symbol) [InlineData("AGS.BR")] [InlineData("PPL.TO")] [InlineData("TSLA")] + [InlineData("AAP")] + [InlineData("MTG")] public async Task GetCashFlowStatementPerQuarter(string symbol) { var result = await api.GetCashFlowStatementAsync(symbol, Period.Quarter, limit: 10000); @@ -204,13 +210,14 @@ public async Task GetCashFlowStatementPerQuarter(string symbol) [InlineData("AGS.BR")] [InlineData("PPL.TO")] [InlineData("TSLA")] + [InlineData("AAP")] + [InlineData("MTG")] public async Task GetBalanceSheetStatement(string symbol) { - var result = await api.GetBalanceSheetStatementAsync(symbol, Period.Annual, 5); + var result = await api.GetBalanceSheetStatementAsync(symbol, Period.Annual, 10000); result.AssertNoErrors(); Assert.NotEmpty(result.Data); - Assert.Equal(5, result.Data.Count); Assert.All(result.Data, data => Assert.Equal(symbol, data.Symbol)); } @@ -220,6 +227,8 @@ public async Task GetBalanceSheetStatement(string symbol) [InlineData("AGS.BR")] [InlineData("PPL.TO")] [InlineData("TSLA")] + [InlineData("AAP")] + [InlineData("MTG")] public async Task GetBalanceSheetStatementPerQuarter(string symbol) { var result = await api.GetBalanceSheetStatementAsync(symbol, Period.Quarter, limit: 10000);