Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUX-1511] Error/warning replay #148

Open
9999years opened this issue Oct 31, 2023 · 0 comments
Open

[DUX-1511] Error/warning replay #148

9999years opened this issue Oct 31, 2023 · 0 comments
Labels
linear Created by Linear-GitHub Sync Medium priority Created by Linear-GitHub Sync

Comments

@9999years
Copy link
Member

9999years commented Oct 31, 2023

There's a few quality-of-life issues with errors and warnings.

Warnings are only printed once, so if the module isn't changed warnings won't be shown again. We could save warnings and print them out on each reload.

Similarly, errors can get buried under compilation output, so it could be useful to replay those as well.

We already parse compilation output, so this should be fairly easy to fix.

Note: If a file is compiled, then an error is introduced, and then the file is reverted back to its original form, it will be reloaded but no [n of m] Compiling ModuleName message will be printed; this means that we need some more sophisticated logic than just looking at compilation messages to determine when to clear diagnostics for a file.

From SyncLinear.com | DUX-1511

@9999years 9999years added the Medium priority Created by Linear-GitHub Sync label Oct 31, 2023
@github-actions github-actions bot added the linear Created by Linear-GitHub Sync label Oct 31, 2023
@9999years 9999years changed the title [DUX-1511] Error replay [DUX-1511] Error/warning replay Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linear Created by Linear-GitHub Sync Medium priority Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

1 participant