Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logfiles and absolute paths on windows #349

Closed
petrelharp opened this issue Aug 29, 2022 · 1 comment
Closed

logfiles and absolute paths on windows #349

petrelharp opened this issue Aug 29, 2022 · 1 comment

Comments

@petrelharp
Copy link
Collaborator

Over in popsim-consortium/stdpopsim#1342 we've run into an issue that if you pass createLogFile an absolute path in Windows it erroneously interprets it as a relative path. Ben says that

I see the bug in log_file.cpp at line 61; it decides whether the path given by the user is an absolute path or not by checking whether the first character is '/' or not. You might put alternative logic in a #ifndef _WIN32 block there. See Eidos_ResolvedPath() at eidos_globals.cpp:1182 for a somewhat similar situation.

@bhaller
Copy link
Contributor

bhaller commented Sep 8, 2022

OK, having sorted out the GitHub Actions issues that were getting in my way, it is now clear that I have managed to fix this issue. Closing.

@bhaller bhaller closed this as completed Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants