Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model or Prompt condition is not written correctly. #52

Open
XvKuoMing opened this issue Aug 22, 2024 · 0 comments
Open

Model or Prompt condition is not written correctly. #52

XvKuoMing opened this issue Aug 22, 2024 · 0 comments

Comments

@XvKuoMing
Copy link

Hello! I was looking at your sdk and I think I found a bug in file: zhipuai-sdk-python-v4/zhipuai/api_resource/videos/videos.py (branch main, row 45)
The code you've written checks twice the same condition

if not model and not model:
    raise ValueError("At least one of `model` and `prompt` must be provided.") 

I suppose it should be like this:

if not model and not prompt:
    raise ValueError("At least one of `model` and `prompt` must be provided.") 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant