-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Endless failed request polling loop #163
Comments
I was still able to reproduce this bug on v9.0.3 |
In the PR that is linked to in the timeline above and was closed, I made this comment:
@Gudahtt Do you still think following that route would be a proper fix here? |
Unfortunately I don't recall the details of that solution |
For clarity, a solution here would be to figure out a way to have the block tracker ignore internally-added listeners. More details here: https://consensys.slack.com/archives/C06FXU326RL/p1718910083555919?thread_ts=1718130645.943409&cid=C06FXU326RL |
The polling block tracker has been observed being stuck in an endless loop (e.g. MetaMask/metamask-extension#17040).
I was able to reproduce this scenario by using MetaMask extension to switch to a network that will fail to respond to requests. This results in an endless loop of failed requests, even after switching away (i.e. even after there are no more listeners). In the debugger I confirmed that the only active listeners were internal to the block tracker itself (specifically this listener).
The text was updated successfully, but these errors were encountered: