Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse amount from ETH QR string in the Send To view #4332

Open
driquelme opened this issue May 16, 2022 · 1 comment
Open

Parse amount from ETH QR string in the Send To view #4332

driquelme opened this issue May 16, 2022 · 1 comment
Labels
area-transactions feature-request Feature requested by the MetaMask community team-confirmations-planning (only for internal use within Confirmations team)

Comments

@driquelme
Copy link

driquelme commented May 16, 2022

Description

Currently, Metamask mobile does not extract the amount from an ETH QR string that contains the price in addition to the address in the Send To view. It would be convenient for the amount to be pre-populated so that the user does not have to enter it manually. Usually, these values are very complicated, and it's cumbersome and difficult to enter them correctly.

Technical Details

  • Modify QR scanning code to parse the amount in an address string that contains this value. An example of such string could look like this ethereum:<address>[?value=<value>].

Acceptance Criteria

  • When scanning an ETH QR code that includes the amount, this value has to be automatically populated in the UI where the amount is currently entered.

Scenario:

  • GIVEN a QR code that encodes an amount
  • WHEN a user scans the QR, the value appears pre-populated in Metamask in the screen where it has to be entered by the user.
  • AND user does not need to enter an amount to send the transaction

References

@driquelme driquelme changed the title Parse amount from ETH QR string Parse amount from ETH QR string in the Send To view May 25, 2022
@bschorchit bschorchit added team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead area-transactions feature-request Feature requested by the MetaMask community labels Feb 9, 2023
@hilvmason hilvmason added team-confirmations-planning (only for internal use within Confirmations team) and removed team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead labels Jun 5, 2023
@RolandSassen
Copy link

Hi, is there any progress here? Thanks, Roland

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-transactions feature-request Feature requested by the MetaMask community team-confirmations-planning (only for internal use within Confirmations team)
Projects
None yet
Development

No branches or pull requests

4 participants