Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

gopls does not start behind a blocking proxy #3204

Closed
neclepsio opened this issue Apr 24, 2020 · 2 comments · Fixed by #3205
Closed

gopls does not start behind a blocking proxy #3204

neclepsio opened this issue Apr 24, 2020 · 2 comments · Fixed by #3205

Comments

@neclepsio
Copy link
Contributor

neclepsio commented Apr 24, 2020

What version of Go, VS Code & VS Code Go extension are you using?

  • Run go version to get version of Go
    • 1.14.2
  • Run code -v or code-insiders -v to get version of VS Code or VS Code Insiders
    • 1.44.2
  • Check your installed extensions to get the version of the VS Code Go extension
    • 0.11.4
  • Run go env GOOS GOARCH to get the operating system and processor architecture details
    • windows amd64

Describe the bug

Behind a proxy which redirects to a login page, golps does not start. Apprently, it fails checking the version. The following error is printed in developer tools console. When VS Code is started with internet connection, the server works correctly.

console.ts:137 [Extension Host] stack trace: TypeError: Invalid Version: null
	at new SemVer (c:\[...]\Microsoft VS Code\code-portable-data\extensions\ms-vscode.go-0.14.1\node_modules\semver\semver.js:314:11)
	at compare (c:\[...]\Microsoft VS Code\code-portable-data\extensions\ms-vscode.go-0.14.1\node_modules\semver\semver.js:647:10)
	at rcompare (c:\[...]\Microsoft VS Code\code-portable-data\extensions\ms-vscode.go-0.14.1\node_modules\semver\semver.js:664:10)
	at Array.sort (<anonymous>)
	at c:\[...]\Microsoft VS Code\code-portable-data\extensions\ms-vscode.go-0.14.1\out\src\goLanguageServer.js:428:18
	at Generator.next (<anonymous>)
	at fulfilled (c:\[...]\Microsoft VS Code\code-portable-data\extensions\ms-vscode.go-0.14.1\out\src\goLanguageServer.js:9:58)
	at processTicksAndRejections (internal/process/task_queues.js:85:5)
@neclepsio
Copy link
Contributor Author

neclepsio commented Apr 24, 2020

Upon further inspection, at goLanguageServer.js:428, versions is [null, null, ..., null], one for each line of the proxy response (the login page).

In don't think the extension should be able to login, but it should use the currently installed version.

@neclepsio neclepsio changed the title gopls does not start without internet connection gopls does not start behind a blocking proxy Apr 24, 2020
neclepsio added a commit to neclepsio/vscode-go that referenced this issue Apr 24, 2020
@ramya-rao-a
Copy link
Contributor

The latest update 0.14.2 has the fix for this, Thanks @neclepsio

@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants