Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Show correct placeholder when extracting method #2799

Merged
merged 1 commit into from
Oct 6, 2019
Merged

Show correct placeholder when extracting method #2799

merged 1 commit into from
Oct 6, 2019

Conversation

romanlevin
Copy link
Contributor

Currently the placeholder text when extracting a function or a variable is

Please enter a name for the extracted variable.

With this change, in the case of extracting a function, the placeholder text will be

Please enter a name for the extracted method.

Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Looks like this is your first PR contribution to this project @romanlevin, Thanks & Welcome!

@ramya-rao-a ramya-rao-a merged commit 3d14fed into microsoft:master Oct 6, 2019
@romanlevin romanlevin deleted the patch-1 branch October 7, 2019 08:36
@romanlevin
Copy link
Contributor Author

@ramya-rao-a thanks!

@ramya-rao-a
Copy link
Contributor

The latest update to this extension (0.11.8) has this fix in.

Thanks @romanlevin and Happy Coding!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants