This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Use mod file to determine module mode when debugging #2846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SteelPhase I put something together that should help with #2828, but I haven't had the time to test it. Do you think you can take this for a spin? :) |
|
I'll try it out in the morning, and report back |
|
Tested it in outside of GOPATH and it works ok. When I test it inside GOPATH i get |
|
Thanks @SteelPhase, I pushed a fix, can you try again? |
|
This appears to be working as expected |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix the issue in #2828 where code under GOPATH gets debugged under the assumption that we are not in module mode if GO111MODULE is not
on.