Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging throughout the extension #1131

Closed
1 task
brettcannon opened this issue Mar 20, 2018 · 4 comments
Closed
1 task

Add logging throughout the extension #1131

brettcannon opened this issue Mar 20, 2018 · 4 comments
Assignees
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.

Comments

@brettcannon
Copy link
Member

brettcannon commented Mar 20, 2018

And VS Code should have something for this in their March release.

  • Ensure errors logged in extension are not (via some config or ability to mock) logged during unit tests
    (else this pollutes the test output and could be confusing).
    Note: Errors are forcibly raised in unit tests.
@brettcannon brettcannon added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Mar 20, 2018
@brettcannon brettcannon changed the title Add logging through the extension Add logging throughout the extension Apr 16, 2018
@brettcannon
Copy link
Member Author

Any place we execute something behind the scenes through a system call we should document, e.g. the command we use to discover tests, to run them, etc.

@brettcannon
Copy link
Member Author

Duplicate of #2156

@brettcannon brettcannon marked this as a duplicate of #2156 Sep 19, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Oct 17, 2018
@brettcannon brettcannon reopened this Jun 17, 2019
@luabud luabud added this to the 2019 - June Sprint 12 milestone Jun 18, 2019
@kimadeline
Copy link

kimadeline commented Jun 19, 2019

Todo

  • log all extension commands being run behind the scenes in the Python output panel, except for testing (stays in its own testing window)
  • for every command being run, display
> path/to/command -args -args2
cwd: current/working/directory // optional line if there is no directory parameter passed to the logging function
  • make sure that the commands and their output are being logged in VSCode's devtools
  • Ensure errors logged in extension are not (via some config or ability to mock) logged during unit tests
  • check that it works for:
    • vcode single workspaces
    • vscode multi-folder workspaces
    • folders
    • single files

Later/separate PR:

@ericsnowcurrently
Copy link
Member

I've verified that, using master, I now see commands logged in the "Python" output panel.

@ghost ghost removed the needs PR label Jul 8, 2019
@ericsnowcurrently ericsnowcurrently removed their assignment Jul 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Development

No branches or pull requests

4 participants