Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update extension to target Node 10.2 #1138

Closed
DonJayamanne opened this issue Mar 21, 2018 · 2 comments
Closed

Update extension to target Node 10.2 #1138

DonJayamanne opened this issue Mar 21, 2018 · 2 comments
Assignees
@DonJayamanne
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Milestone
2019, week 15 - A...

Comments

@DonJayamanne
Copy link

DonJayamanne commented Mar 21, 2018 •
edited
Loading

Change target to es2017 es2018
Change libs to es2015, es2016, es2017, es2018

  • Check https://node.green/

  • Check version of node shipped with VS Code (depends on version of Electron used by VS Code)

  • Will also need optionally udpate data science React code
@DonJayamanne DonJayamanne added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Mar 21, 2018
@DonJayamanne DonJayamanne added this to the April 2018 milestone Mar 21, 2018
@DonJayamanne DonJayamanne changed the title Consider updating tsconfig to transpile TS into ES2017 compatible JS code Update tsconfig to transpile TS into ES2017 compatible JS code Mar 21, 2018
@DonJayamanne DonJayamanne changed the title Update tsconfig to transpile TS into ES2017 compatible JS code Consider updating tsconfig to transpile TS into ES2017 compatible JS code Mar 21, 2018
@DonJayamanne DonJayamanne removed this from the April 2018 milestone Mar 21, 2018
@DonJayamanne
Copy link
Author

This might be a possibility when VSC moves to Electron 3, soon.

@DonJayamanne DonJayamanne changed the title Consider updating tsconfig to transpile TS into ES2017 compatible JS code Consider updating tsconfig to transpile TS into ES2018 compatible JS code Jan 14, 2019
@DonJayamanne DonJayamanne added the important Issue identified as high-priority label Jan 29, 2019
@DonJayamanne DonJayamanne changed the title Consider updating tsconfig to transpile TS into ES2018 compatible JS code Consider updating tsconfig to target Node 10.2 Jan 29, 2019
@DonJayamanne DonJayamanne changed the title Consider updating tsconfig to target Node 10.2 Consider updating extension to target Node 10.2 Jan 29, 2019
@DonJayamanne DonJayamanne changed the title Consider updating extension to target Node 10.2 Update extension to target Node 10.2 Jan 29, 2019
@luabud luabud removed the important Issue identified as high-priority label Mar 12, 2019
@DonJayamanne
Copy link
Author

DonJayamanne commented Mar 13, 2019 •
edited
Loading

Solution:

  • Modify tsconfig accordingly
  • Modify Azdo to use Node 10.xx (check version defined in contributing doc of VSC)
  • Update our contributing docs
  • Ensure we use nvm.rc

@DonJayamanne DonJayamanne removed this from the 2019, week 11 - March Sprint 6 milestone Mar 13, 2019
@DonJayamanne DonJayamanne mentioned this issue Apr 11, 2019
Merged
3 tasks
@DonJayamanne DonJayamanne added P0 and removed P0 labels Apr 15, 2019
@ghost ghost removed the needs PR label Apr 16, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Milestone
2019, week 15 - April Sprint 8
Development

No branches or pull requests
4 participants
@ericsnowcurrently @DonJayamanne @qubitron @luabud