Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use yarn install --frozen-lockfile for CI #1374

Closed
brettcannon opened this issue Apr 11, 2018 · 0 comments · Fixed by #1375
Closed

Use yarn install --frozen-lockfile for CI #1374

brettcannon opened this issue Apr 11, 2018 · 0 comments · Fixed by #1375
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.

Comments

@brettcannon
Copy link
Member

https://yarnpkg.com/en/docs/cli/install#toc-yarn-install-frozen-lockfile

Basically we are not making sure the lockfile is always up-to-date and the results are consistent across systems. If this is too burdensome as-is then we need to start pinning our dependencies as they are otherwise constantly shifting underneath us and make reproducible builds impossible.
@brettcannon brettcannon added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Apr 11, 2018
@brettcannon brettcannon mentioned this issue Apr 11, 2018
Merged
5 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Jul 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pin all production dependencies brettcannon/vscode-python
1 participant
@brettcannon