Indentation not made after a function parameter list with a type hint

[brettcannon]

Actual behavior

Expected behavior

The cursor to indent after hitting Enter.

Steps to reproduce:

def foo(x: int):

[DonJayamanne]

Time to start writing unit tests for this.

[DonJayamanne]

Here's what we have today:

{
    beforeText: /^\s*(?:def|class|for|if|elif|else|while|try|with|finally|except)\b.*:\s*\S+/,
    action: { indentAction: IndentAction.None }
},
{
    beforeText: /^\s*(?:def|class|for|if|elif|else|while|try|with|finally|except|async)\b.*?:\s*/,
    action: { indentAction: IndentAction.Indent }
},
{
    beforeText: /^\s+(continue|break|return)\b.*/,
    afterText: /\s+$/,
    action: { indentAction: IndentAction.Outdent }
}

If we have the python code def foo(x: int):, then indentation breaks, even if we were to fix the second rule.

I'd like to ensure we have covered all possible scenarios in this issue that can be used as test cases for each of the rules. Unfortunately we don't have any tests for these rules and I'm not comfortable making changes to this.

Time to start hunting down all issues related to indentation and prepare a list of test cases/issues.

[nottoseethesun]

Is this unrelated to microsoft/monaco-editor#612 ?

[DonJayamanne]

This seems to be caused by the implementation of editor.formatOnType