Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check document uri scheme to determine if the document lives on disk #1545

Closed
DonJayamanne opened this issue Apr 28, 2018 · 1 comment
Closed

Check document uri scheme to determine if the document lives on disk #1545

DonJayamanne opened this issue Apr 28, 2018 · 1 comment
Assignees
@DonJayamanne
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Milestone
May 2018

Comments

@DonJayamanne
Copy link 

Language Identifiers and Document Selectors

The addition of filesystem providers means that not all files live on disk. While there were similar cases before, this is now much more apparent and extensions should be aware of this. The short, but important message is that not all documents live on disk and if your extension uses relies on disk-access you must check the scheme first.

This is part of the change coming in the April release of VSC.
There's a potential for this to break with remote files (if anyone were to use any remote file apis along with python files).
@DonJayamanne DonJayamanne added feature-request Request for new features or functionality needs PR labels Apr 28, 2018
@DonJayamanne DonJayamanne added this to the May 2018 milestone Apr 28, 2018
@DonJayamanne DonJayamanne self-assigned this Apr 28, 2018
@brettcannon brettcannon changed the title Check document uri scheme to determine if the document lives on disc Check document uri scheme to determine if the document lives on disk Apr 30, 2018
@brettcannon brettcannon added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. and removed feature-request Request for new features or functionality labels Apr 30, 2018
@DonJayamanne
Copy link
Author

Confirmed, nothing to be done here.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Milestone
May 2018
Development

No branches or pull requests
2 participants
@brettcannon @DonJayamanne