Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have pvsc-dev-ext.py capture output for debugging #2483

Closed
brettcannon opened this issue Sep 4, 2018 · 0 comments · Fixed by #2515
Closed

Have pvsc-dev-ext.py capture output for debugging #2483

brettcannon opened this issue Sep 4, 2018 · 0 comments · Fixed by #2515
Assignees
@brettcannon
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. good first issue

Comments

@brettcannon
Copy link
Member

As brought up by @d3r3kk , if pvsc-dev-ext.py fails because a command returned a non-zero return code there is no captured output to look at. Should probably fix that. 😉 (subprocess.CompletedProcess.check_returncode() will automatically include stdout and stderr in the exception.)
@brettcannon brettcannon added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Sep 4, 2018
@brettcannon brettcannon self-assigned this Sep 4, 2018
@brettcannon brettcannon mentioned this issue Sep 6, 2018
Merged
6 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brettcannon brettcannon

Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. good first issue
Projects
None yet
Milestone
No milestone
1 participant
@brettcannon