Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for mypy result regex matching #2696

Closed
brettcannon opened this issue Sep 26, 2018 · 2 comments
Closed

Add a test for mypy result regex matching #2696

brettcannon opened this issue Sep 26, 2018 · 2 comments
Assignees
Labels
area-linting debt Covers everything internal: CI, testing, refactoring of the codebase, etc.

Comments

@brettcannon
Copy link
Member

brettcannon commented Sep 26, 2018

A test for bfcd225 .

Need to also check that the regex doesn't affect what mypy checks and is only for teasing out results (e.g. this won't cause mypy to check a README file suddenly).

@brettcannon brettcannon added area-linting needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Sep 26, 2018
@ericsnowcurrently ericsnowcurrently self-assigned this Oct 2, 2018
@ericsnowcurrently
Copy link
Member

Why is that check (target vs. results) needed relative to MyPy? From what I can tell, the handled filenames are determined elsewhere in the extension.

@DonJayamanne
Copy link

rom what I can tell, the handled filenames are determined elsewhere in the extension.

That's because the file name is not part of the result. We run linters on a file by file basis, hence at the calling location we know the file that is being linted.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-linting debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Development

No branches or pull requests

3 participants