Properly detect macOS/Linux/Windows incompatibility for the language server

[samuelchen]

Environment data

• VS Code version: 1.27.2
• Extension version (available under the Extensions sidebar): 2018.8.0
• OS and version: MacOS EI Captain 10.11.6
• Python version (& distribution if applicable, e.g. Anaconda): 3.7.0 from Brew
• Type of virtual environment used (N/A | venv | virtualenv | conda | ...): virtualenv
• Relevant/affected Python packages and their versions: N/A

Actual behavior

Error log shows in "output"

Expected behavior

N/A

Steps to reproduce:

N/A

Logs

Starting Microsoft Python language server.
dyld: lazy symbol binding failed: Symbol not found: _clock_gettime
  Referenced from: /Users/samuel/.vscode/extensions/ms-python.python-2018.8.0/languageServer/libcoreclr.dylib (which was built for Mac OS X 10.12)
  Expected in: /usr/lib/libSystem.B.dylib

dyld: Symbol not found: _clock_gettime
  Referenced from: /Users/samuel/.vscode/extensions/ms-python.python-2018.8.0/languageServer/libcoreclr.dylib (which was built for Mac OS X 10.12)
  Expected in: /usr/lib/libSystem.B.dylib

[Info  - 11:50:16 PM] Connection to server got closed. Server will restart.
dyld: lazy symbol binding failed: Symbol not found: _clock_gettime
  Referenced from: /Users/samuel/.vscode/extensions/ms-python.python-2018.8.0/languageServer/libcoreclr.dylib (which was built for Mac OS X 10.12)
  Expected in: /usr/lib/libSystem.B.dylib

dyld: Symbol not found: _clock_gettime
  Referenced from: /Users/samuel/.vscode/extensions/ms-python.python-2018.8.0/languageServer/libcoreclr.dylib (which was built for Mac OS X 10.12)
  Expected in: /usr/lib/libSystem.B.dylib

[Info  - 11:50:17 PM] Connection to server got closed. Server will restart.
dyld: lazy symbol binding failed: Symbol not found: _clock_gettime
  Referenced from: /Users/samuel/.vscode/extensions/ms-python.python-2018.8.0/languageServer/libcoreclr.dylib (which was built for Mac OS X 10.12)
  Expected in: /usr/lib/libSystem.B.dylib

dyld: Symbol not found: _clock_gettime
  Referenced from: /Users/samuel/.vscode/extensions/ms-python.python-2018.8.0/languageServer/libcoreclr.dylib (which was built for Mac OS X 10.12)
  Expected in: /usr/lib/libSystem.B.dylib

[Info  - 11:50:18 PM] Connection to server got closed. Server will restart.
dyld: lazy symbol binding failed: Symbol not found: _clock_gettime
  Referenced from: /Users/samuel/.vscode/extensions/ms-python.python-2018.8.0/languageServer/libcoreclr.dylib (which was built for Mac OS X 10.12)
  Expected in: /usr/lib/libSystem.B.dylib

dyld: Symbol not found: _clock_gettime
  Referenced from: /Users/samuel/.vscode/extensions/ms-python.python-2018.8.0/languageServer/libcoreclr.dylib (which was built for Mac OS X 10.12)
  Expected in: /usr/lib/libSystem.B.dylib

[Info  - 11:50:18 PM] Connection to server got closed. Server will restart.
dyld: lazy symbol binding failed: Symbol not found: _clock_gettime
  Referenced from: /Users/samuel/.vscode/extensions/ms-python.python-2018.8.0/languageServer/libcoreclr.dylib (which was built for Mac OS X 10.12)
  Expected in: /usr/lib/libSystem.B.dylib

dyld: Symbol not found: _clock_gettime
  Referenced from: /Users/samuel/.vscode/extensions/ms-python.python-2018.8.0/languageServer/libcoreclr.dylib (which was built for Mac OS X 10.12)
  Expected in: /usr/lib/libSystem.B.dylib

[Error - 11:50:19 PM] Connection to server got closed. Server will not be restarted.

[brettcannon]

Did you get a banner about the language server not supporting macOS 10.11? (Notice the message "which was built for Mac OS X 10.12" in the output.)

[samuelchen]

@brettcannon Thank you for the reply.
I did not get a banner about the language server not support the macOS version. I just found the message in the log.

[samuelchen]

Besides the banner displaying, is there anyway to make it work in macOS 10.11 ?

[DonJayamanne]

Please could you install the development version form here and let us know what you get?
Instructions for installing the development version can be found here https://github.com/Microsoft/vscode-python/blob/master/CONTRIBUTING.md#development-build

[ev-dev]

Also had this happen running on El Capitan 10.11, didn't display a incompatibility banner vs code let me download and install language server which then just errored out immediately on reload. Was confusing since VS Code prompted the recommendation to try out the language server first. Would be good to notate the restricted system requirements in the extension info page or elsewhere while the bug persists

[DonJayamanne]

While this might not work properly on Mac, I've found that we're not checking for support on other Unix OS (https://github.com/dotnet/core/blob/master/release-notes/2.1/2.1-supported-os.md)

E.g. Ubuntu <18 isn't supported and we're not checking this.
Surely this would be required when LS become stable.

[DonJayamanne]

Suggestion, just drop getos and make use of distro instead.

Benefits of pypi distro over npm getos:

• No need of getos (slightly smaller bundle and faster load times of extension)
  • Right now getos gets invoked when the extension loads unnecessarily.
• We can use native nodejs for Windows and Mac OS
• Use python code to detect Linux versions.
• getos was not updated for 2 years until we reported an issue with regards to webpack (then again there aren't too many issues filed against it).

[brettcannon]

Distro on PyPI.

We shouldn't split the checking across multiple languages. If we're going to do it in Python we should just do it all in Python. We can use the platform module very easily to get the macOS version and the same for Windows. So if we are going to drop into Python to do this check then I think we should go all-in and centralize the checking (and it can be as simple as a script that we run that uses exit codes to signal if the language server is worth downloading.

[DonJayamanne]

@brettcannon
Agreed

[brettcannon]

• Test Python code
• Fix PyPI dependency installation
• Test macOS
• Test Linux

[samuelchen]

@DonJayamanne sorry too late to answer.
I tried Jedi and it worked. Later I upgraded memory & SSD so that I could upgrade to latest MacOS. It works well.