Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python.formatting.formatOnSave false seems to have no effect #285

Closed
faassen opened this issue Nov 24, 2017 · 0 comments · Fixed by #312
Closed

python.formatting.formatOnSave false seems to have no effect #285

faassen opened this issue Nov 24, 2017 · 0 comments · Fixed by #312
Labels
area-formatting bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@faassen
Copy link

faassen commented Nov 24, 2017

Environment data

VS Code version: 1.18.1
Python Extension version: 0.8.0
Python Version: 3.6.2, 2.7.14
OS and version: Fedora 26

Actual behavior

When I save autopep8 reformats the code, even though I set python.formatting.formatOnSave to false. I do have 'editor.formatOnSave' set to true, but I want to disable save formatting specifically for Python, not for all languages in my project.

Expected behavior

When I set python.formatting.formatOnSave to false, I expect no formatting to happen when I save, even though 'editor.formatOnSave' is true.

Steps to reproduce:

  • set the setting to false, with editor.formatOnSave to true.

  • create a Python file that would be formatted by autopep8

  • save

@brettcannon brettcannon added awaiting 1-verification area-formatting bug Issue identified by VS Code Team member as probable bug labels Nov 24, 2017
DonJayamanne added a commit that referenced this issue Nov 28, 2017
… setting (#312)

Fixes #285 
* This setting is deprecated in favour of the standard vs code setting to enable the feature of formattig on save.
* Also took the liberty of refactoring some files (reduces code review for re-engineering of execution engine).
* Removed unused file 'windowsService.ts'
@brettcannon brettcannon added this to the December 2017 milestone Nov 28, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-formatting bug Issue identified by VS Code Team member as probable bug
Projects
None yet
3 participants