Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct long-standing test problem Formatting "before all" hook to do with black not being installed (py3.4, 3.5) #2999

Closed
d3r3kk opened this issue Oct 24, 2018 · 0 comments · Fixed by #3002
Closed

Correct long-standing test problem Formatting "before all" hook to do with black not being installed (py3.4, 3.5) #2999

d3r3kk opened this issue Oct 24, 2018 · 0 comments · Fixed by #3002
Assignees
@d3r3kk
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Milestone
2018, week 42 - O...

Comments

@d3r3kk
Copy link

d3r3kk commented Oct 24, 2018

Black will not be present for our test environment in any Python version < 3.6 due to the limitation that Black itself imposes.

Our formatting tests are failing during setup because they are expecting it.

Callstack

Error: Module 'black' not installed. at PythonExecutionService.<anonymous> (out/client/common/process/pythonProcess.js:9:9298) at Generator.next (<anonymous>) at fulfilled (out/client/common/process/pythonProcess.js:9:2415) at <anonymous>

Screenshot of build result:

image

Specific build

See a specific failing build on Azure DevOps CI build here
@d3r3kk d3r3kk added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Oct 24, 2018
@d3r3kk d3r3kk self-assigned this Oct 24, 2018
d3r3kk added a commit to d3r3kk/vscode-python that referenced this issue Oct 24, 2018
@d3r3kk
Correct test failures related to the Black formatter.
fbd47ec 
Fixes microsoft#2999

- Check for all unsupported versions of Python during formatter tests
- Skip unsupported versions
- Rename test suite to make it more grep-able
@d3r3kk d3r3kk mentioned this issue Oct 24, 2018
Merged
5 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Nov 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@d3r3kk d3r3kk

Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Milestone
2018, week 42 - October Sprint 2
Development

Successfully merging a pull request may close this issue.

Correct test failures related to the Black formatter. d3r3kk/vscode-python
1 participant
@d3r3kk