You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Processes spawned need to be killed in the dispose handler.
I.e. when extension is unloaded/deactivated we need to shutdown all processes started by the extension.
Kill debugger processes spawned
Kill linter, formatter, jedi processes spawned
The text was updated successfully, but these errors were encountered:
DonJayamanne
added
bug
Issue identified by VS Code Team member as probable bug
needs PR
debt
Covers everything internal: CI, testing, refactoring of the codebase, etc.
labels
Nov 13, 2018
After reloading the window the processes are no longer in the VS Code Process Explorer, but they are still running on the OS until I kill them of manually.
Note, if you start child processes with posix pgid attributes you can kill of child processes automatically when killing the parent process.
Here is some go-code I am using:
// NOTE: This code does not work for windows, therefore separate compile units// StartProcess _funcStartProcess(cmd*exec.Cmd) error {
cmd.SysProcAttr=&syscall.SysProcAttr{Setpgid: true}
returncmd.Start()
}
// KillProcess _funcKillProcess(cmd*exec.Cmd) error {
// job.Cmd.Process.Kill()returnsyscall.Kill(-cmd.Process.Pid, syscall.SIGKILL)
}
Processes spawned need to be killed in the
dispose
handler.I.e. when extension is unloaded/deactivated we need to shutdown all processes started by the extension.
The text was updated successfully, but these errors were encountered: