Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure no new npm modules get excluded accidentally by webpack #3468

Closed
DonJayamanne opened this issue Nov 27, 2018 · 0 comments
Closed

Ensure no new npm modules get excluded accidentally by webpack #3468

DonJayamanne opened this issue Nov 27, 2018 · 0 comments
Assignees
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority

Comments

@DonJayamanne
Copy link

DonJayamanne commented Nov 27, 2018

Currently webpack spits out a couple of warning messages about not being to include a few dependencies.
These have been reviewed and can be safely ignored, however we need a build step to ensure no new modules get ignored.

Here's whats generated today:

    WARNING in ./node_modules/encoding/lib/iconv-loader.js 9:12-34
    Critical dependency: the request of a dependency is an expression
     @ ./node_modules/encoding/lib/encoding.js
     @ ./node_modules/node-fetch/lib/body.js
     @ ./node_modules/node-fetch/index.js
     @ ./node_modules/@jupyterlab/services/lib/serverconnection.js
     @ ./node_modules/@jupyterlab/services/lib/index.js

    WARNING in ./node_modules/ws/lib/BufferUtil.js
    Module not found: Error: Can't resolve 'bufferutil' in '/Users/donjayamanne/.vscode-insiders/extensions/pythonVSCode/node_modules/ws/lib'
     @ ./node_modules/ws/lib/BufferUtil.js
     @ ./node_modules/ws/lib/Receiver.js
     @ ./node_modules/ws/index.js
     @ ./node_modules/@jupyterlab/services/lib/serverconnection.js
     @ ./node_modules/@jupyterlab/services/lib/index.js

    WARNING in ./node_modules/ws/lib/Validation.js
    Module not found: Error: Can't resolve 'utf-8-validate' in '/Users/donjayamanne/.vscode-insiders/extensions/pythonVSCode/node_modules/ws/lib'
     @ ./node_modules/ws/lib/Validation.js
     @ ./node_modules/ws/lib/Receiver.js
     @ ./node_modules/ws/index.js
     @ ./node_modules/@jupyterlab/services/lib/serverconnection.js
     @ ./node_modules/@jupyterlab/services/lib/index.js
@DonJayamanne DonJayamanne added important Issue identified as high-priority debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Nov 27, 2018
@DonJayamanne DonJayamanne self-assigned this Jan 14, 2019
@ghost ghost removed the needs PR label Jan 16, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority
Projects
None yet
Development

No branches or pull requests

2 participants