Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always bundle extension using WebPack #3479

Closed
DonJayamanne opened this issue Nov 27, 2018 · 0 comments
Closed

Always bundle extension using WebPack #3479

DonJayamanne opened this issue Nov 27, 2018 · 0 comments
Assignees
@DonJayamanne
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority
Milestone
2018, week 48 - D...

Comments

@DonJayamanne
Copy link

Currently we bundle the extension using bold the old and new (webpack) way.
After the Nov release we need to change the build to always use the webpack approach

This is a simple change.

Changes:

  • Remove vscode:prepublish from package.json file.
@DonJayamanne DonJayamanne added important Issue identified as high-priority debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Nov 27, 2018
@DonJayamanne DonJayamanne self-assigned this Dec 8, 2018
@DonJayamanne DonJayamanne mentioned this issue Dec 10, 2018
Merged
3 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Jan 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority
Projects
None yet
Milestone
2018, week 48 - Dec sprint 1
Development

No branches or pull requests
2 participants
@brettcannon @DonJayamanne