Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Jedi if Language Server fails to activate #3633

Closed
2 tasks
DonJayamanne opened this issue Dec 11, 2018 · 0 comments
Closed
2 tasks

Use Jedi if Language Server fails to activate #3633

DonJayamanne opened this issue Dec 11, 2018 · 0 comments
Assignees
@karrtikr
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority meta Issue that is tracking an overall project
Milestone
2019, week 1 - Ja...

Comments

@DonJayamanne
Copy link

DonJayamanne commented Dec 11, 2018 •
edited
Loading

If Language Server fails to activate we need to revert to Jedi (after displaying a message to the user).
Else user is unable to use the extension.

Right now we let the extension fall over.

Display the following message is LS fails to start: "We encountered an issue starting the Language Server. Reverting to the alternative, Jedi. Check the Output panel for details."
No buttons on this message.
@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug needs PR important Issue identified as high-priority labels Dec 11, 2018
@brettcannon brettcannon added area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. debt Covers everything internal: CI, testing, refactoring of the codebase, etc. and removed bug Issue identified by VS Code Team member as probable bug labels Dec 11, 2018
@DonJayamanne DonJayamanne added the meta Issue that is tracking an overall project label Dec 12, 2018
@brettcannon brettcannon mentioned this issue Dec 18, 2018
Closed
@karrtikr karrtikr self-assigned this Jan 8, 2019
@karrtikr karrtikr mentioned this issue Jan 9, 2019
Merged
6 tasks
@ghost ghost removed the needs PR label Jan 11, 2019
@DonJayamanne DonJayamanne reopened this Jan 15, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@karrtikr karrtikr

Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority meta Issue that is tracking an overall project
Projects
None yet
Milestone
2019, week 1 - Jan Sprint 1
Development

No branches or pull requests
3 participants
@brettcannon @DonJayamanne @karrtikr