Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When parsing launch.json we need to account for invalid json (unnecessary commas) #4543

Closed
DonJayamanne opened this issue Feb 26, 2019 · 3 comments
Closed

When parsing launch.json we need to account for invalid json (unnecessary commas) #4543

DonJayamanne opened this issue Feb 26, 2019 · 3 comments
Assignees
@DonJayamanne
Labels
area-debugging bug Issue identified by VS Code Team member as probable bug
Milestone
2019, week 15 - A...

Comments

@DonJayamanne
Copy link

For #332
Parsing launch.json fails when there are extra commas in array elements.
Unfortunately this is invalid json, hence JSON.parse bombs out and we display messages to the user (misleading messages).
@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug needs PR area-debugging labels Feb 26, 2019
@DonJayamanne
Copy link
Author

DonJayamanne commented Apr 4, 2019 •
edited
Loading

Prescribed solution:

  • Use jsonc-parser (used in extension today)

@qubitron qubitron added important Issue identified as high-priority and removed good first issue labels Apr 10, 2019
@qubitron
Copy link

Breaks "Debug Test"

@DonJayamanne DonJayamanne added P0 and removed important Issue identified as high-priority labels Apr 16, 2019
@DonJayamanne DonJayamanne self-assigned this Apr 17, 2019
@DonJayamanne DonJayamanne mentioned this issue Apr 17, 2019
Merged
4 tasks
DonJayamanne added a commit that referenced this issue Apr 17, 2019
@DonJayamanne
Accomadate trailing commas in parsed launch.json (#5331)
1799d75 
For #4543
@ericsnowcurrently
Copy link
Member

I was able to verify that on the last release "Debug Test" (via test explorer) fails if I have a trailing comma; and that it works if I use the most recent insiders .vsix.

@ghost ghost removed the needs PR label Apr 22, 2019
@ericsnowcurrently ericsnowcurrently removed their assignment Apr 22, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
area-debugging bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
2019, week 15 - April Sprint 8
Development

No branches or pull requests
3 participants
@ericsnowcurrently @DonJayamanne @qubitron