Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --nothreading option from django debug config #5116

Closed
DonJayamanne opened this issue Apr 4, 2019 · 1 comment
Closed

Remove --nothreading option from django debug config #5116

DonJayamanne opened this issue Apr 4, 2019 · 1 comment
Assignees
@DonJayamanne
Labels
area-debugging debt Covers everything internal: CI, testing, refactoring of the codebase, etc. good first issue important Issue identified as high-priority
Milestone
2019 - May Sprint 11

Comments

@DonJayamanne
Copy link

Based on microsoft/ptvsd#1256 we no longer need this.
If this is the case, we can remove this setting.

TODO: Verify and then remove it.
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Apr 4, 2019
@DonJayamanne DonJayamanne added good first issue needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Apr 4, 2019
@ghost ghost removed triage-needed Needs assignment to the proper sub-team labels Apr 4, 2019
@DonJayamanne DonJayamanne added triage-needed Needs assignment to the proper sub-team area-debugging labels Apr 4, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Apr 4, 2019
@int19h int19h mentioned this issue May 3, 2019
Closed
@DonJayamanne DonJayamanne added the important Issue identified as high-priority label May 3, 2019
@DonJayamanne DonJayamanne added this to the 2019 - May Sprint 11 milestone May 30, 2019
@DonJayamanne DonJayamanne self-assigned this May 30, 2019
@DonJayamanne DonJayamanne mentioned this issue May 30, 2019
Merged
4 tasks
@ericsnowcurrently
Copy link
Member

I've verified that if I add the Django debug config then there is no "--nothreading" in the config's "args".

@ghost ghost removed the needs PR label Jun 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
area-debugging debt Covers everything internal: CI, testing, refactoring of the codebase, etc. good first issue important Issue identified as high-priority
Projects
None yet
Milestone
2019 - May Sprint 11
Development

No branches or pull requests
2 participants
@ericsnowcurrently @DonJayamanne