snippet for def classmethod

[Cologler]

https://github.com/Microsoft/vscode-python/blob/b741e1af6d53cdf94765a6708964d489bd558ff8/snippets/python.json#L146-L153

should be

"body": [ 
    "@classmethod",
    "def ${1:funcname}(cls, ${2:parameter_list}):", 
    "\t${3:pass}" 
]

[karrtikr]

Please provide more info,

• Reasons for changing
• Current behavior
• Expected behavior

[Cologler]

Seems like this is instance method instead of class method.

[karrtikr]

Can you please elaborate? With an example perhaps. I don't understand the issue here. Please fill the issue template

[Cologler]

Current behavior:

When user typing def(class method):

def ${1:funcname}(self, ${2:parameter_list}):
    ${3:pass}

Expected behavior:

When user typing def(class method):

@classmethod
def ${1:funcname}(cls, ${2:parameter_list}):
    ${3:pass}

Reason:

The current behavior is not the class method, why did you name it class method ?

[karrtikr]

Thanks a lot for elaborating. I see what you're saying.

Prescribed solution

Replace

"def(class method)": {
    "prefix": "def(class method)",
    "body": [
        "def ${1:funcname}(self, ${2:parameter_list}):",
        "\t${3:pass}"
    ],
    "description": "Code snippet for a class method"
},,

with

"def(instance method)": {
    "prefix": "def(instance method)",
    "body": [
        "def ${1:funcname}(self, ${2:parameter_list}):",
        "\t${3:pass}"
    ],
    "description": "Code snippet for a instance method"
},
"def(class method)": {
    "prefix": "def(class method)",
    "body": [ 
        "@classmethod",
        "def ${1:funcname}(cls, ${2:parameter_list}):", 
        "\t${3:pass}" 
    ],
    "description": "Code snippet for a class method"
},

[brettcannon]

I would actually just name it "method" as that's what everyone is going to look for as the name.

[janosh]

This looks like an easy fix that fell under the table. Shall I submit the PR?

[brettcannon]

@janosh I would hold off as we are considering dropping all of our snippets.

[janosh]

Interesting. Where is that being tracked?

Ah, here: #14781

[brettcannon]

@janosh correct, we have no control over user-defined snippets, so you can totally have your own copy (or even create your own extension of Python snippets!).

[brettcannon]

Snippets have been removed by #15006, so closing this as out of date.