Path with non-ASCII characters won't hit breakpoints

[kzhui125]

Environment data

VS Code version: 1.19.3
Python Extension version: 0.9.1
Python Version: Python 2.7 64bit
OS and version: Win10 Chinese Simplified

the folder path has chinese string

C:\Users\Name\.vscode\extensions\ms-python.python-0.9.1\pythonFiles\PythonTools\visualstudio_py_debugger.py:1669: UnicodeWarning: Unicode equal comparison failed to convert both arguments to Unicode - interpreting them as being unequal
  if module.filename.lower() == path.abspath(bp.filename).lower():
C:\Users\Name\.vscode\extensions\ms-python.python-0.9.1\pythonFiles\PythonTools\visualstudio_py_debugger.py:1089: UnicodeWarning: Unicode unequal comparison failed to convert both arguments to Unicode - interpreting them as being unequal
  if filename != frame.f_code.co_filename:

{
    // Use IntelliSense to learn about possible attributes.
    // Hover to view descriptions of existing attributes.
    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Python",
            "type": "python",
            "request": "launch",
            "stopOnEntry": false,
            "pythonPath": "${config:python.pythonPath}",
            "program": "${file}",
            "cwd": "${workspaceFolder}",
            "env": {},
            "envFile": "${workspaceFolder}/.env",
            "debugOptions": [
                "RedirectOutput"
            ]
        },
        {
            "type": "node",
            "request": "launch",
            "name": "nodejs",
            "program": "${file}"
        }
    ]
}

[ericsnowcurrently]

@kzhui125, thanks for letting us know about this problem. We're looking into it.

[ericsnowcurrently]

@kzhui125, could you check if you have the same problem under Python 3?

[ericsnowcurrently]

FTR:

• https://github.com/Microsoft/vscode-python/blob/master/pythonFiles/PythonTools/visualstudio_py_debugger.py#L1089
• https://github.com/Microsoft/vscode-python/blob/master/pythonFiles/PythonTools/visualstudio_py_debugger.py#L1669

I expect that this is not a problem under Python 3. Under Python 2 it is problably a matter of coercing bytes to unicode (e.g. in the code that calls add_breakpoint()).

[DonJayamanne]

@ericsnowcurrently worth checking whether this is an issue in the experimental debugger.

[kzhui125]

@ericsnowcurrently no problem using Python 3

Thanks.

[seishun]

I just encountered this issue while trying to debug a Python script that misbehaves with non-ASCII paths. 🤦‍♂️

With Python Experimental, breakpoints don't work at all. With normal Python debugger, breakpoints work but they show up as "Unknown Source".

[brettcannon]

I can confirm that:

1. Old debugger + Python 3 is fine
2. Old debugger + Python 2 just falls over with a Unicode error
3. Experimental debugger + Python 3 is fine
4. Experimental debugger + Python 2 just ignores the breakpoint

So that last one is what we should try to fix.

[DonJayamanne]

File upstream issue microsoft/ptvsd#421

[DonJayamanne]

This has been fixed in the latest version of the experimental debugger.