Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling linting in the first folder of a multi-root workspaces disables all linters in all folders #862

Closed
DonJayamanne opened this issue Feb 22, 2018 · 0 comments · Fixed by #868
Closed

Disabling linting in the first folder of a multi-root workspaces disables all linters in all folders #862

DonJayamanne opened this issue Feb 22, 2018 · 0 comments · Fixed by #868
Assignees
@DonJayamanne
Labels
area-linting bug Issue identified by VS Code Team member as probable bug
Milestone
February 2018

Comments

@DonJayamanne
Copy link

DonJayamanne commented Feb 22, 2018 •
edited
Loading

Create a multi-root setup:

  • Folder1 - Disable linting and point to a python environment without pylint
  • Folder2 - Enable linting and point to another python environment without pylint
  • Open a file in folder 2 and start editing a Python file
  • Prompt to install pylint is not dispalyed (bug)
  • Now enable linting in Folder1
  • Go back and edit the file in folder 2,
  • Prompt to install pylint is now dispalyed

Looks like we're using the wrong flags in multi-root environment for linting.

Problem
@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug area-linting needs PR labels Feb 22, 2018
@DonJayamanne DonJayamanne added this to the February 2018 milestone Feb 22, 2018
@DonJayamanne DonJayamanne changed the title Linting in multi-root workspaces is broken Disabling linting in the first folder of a multi-root workspaces disables all linters in all folders Feb 22, 2018
@DonJayamanne DonJayamanne self-assigned this Feb 22, 2018
@DonJayamanne DonJayamanne mentioned this issue Feb 22, 2018
Merged
DonJayamanne added a commit that referenced this issue Feb 22, 2018
@DonJayamanne
🐛 Use document.uri when linting and checking if linting is enabled or…
1d2020f 
… not (#868)

Fixes #862
@lock lock bot locked as resolved and limited conversation to collaborators Jul 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
area-linting bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
February 2018
2 participants
@brettcannon @DonJayamanne