Korean translation #540
Korean translation #540
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## master #540 +/- ##
==========================================
+ Coverage 60.69% 60.97% +0.28%
==========================================
Files 232 232
Lines 10502 10502
Branches 1830 1830
==========================================
+ Hits 6374 6404 +30
+ Misses 4122 4092 -30
Partials 6 6
Continue to review full report at Codecov.
|
|
Thanks for the PR, @LazyRichard ! I have asked on Twitter for someone to help review your translation. Once we have that then we can accept your PR. |
| { | ||
| "python.command.python.sortImports.title": "Import문 정렬", | ||
| "python.command.python.startREPL.title": "REPL 시작", | ||
| "python.command.python.buildWorkspaceSymbols.title": "작업 영역 기호 빌드", |
There was a problem hiding this comment.
"심벌" is a better translation, but I think it should be a "기호" because it is translated as "기호" in Visual Studio.
There was a problem hiding this comment.
Guys, could you please explain to a non-native but enthusiastic learner of Korean, why is "심벌" better than "기호"? Aren't words of Chinese origin more preferable?
There was a problem hiding this comment.
In the case of a technical term, words that write the original pronunciation more than the translated words maybe more effective in transferring meaning. Because it is not only difficult to search for translated term, but also because there are many different translations depending on who translates the same term. But in this case, Visual Studio team has been already translated many term. so, I think we should follow.
package.nls.ko-kr.json
Outdated
| "python.snippet.launch.externalTerminal.label": "Python: 터미널 (외부)", | ||
| "python.snippet.launch.externalTerminal.description": "외부 터미널/콘솔에서 Python 프로그램 디버그", | ||
| "python.snippet.launch.django.label": "Python: Django", | ||
| "python.snippet.launch.django.description": "Django 어플리케이션 디버그", |
There was a problem hiding this comment.
s/어플리케이션/애플리케이션
All "어플리케이션" in this change should be replaced by "애플리케이션"
There was a problem hiding this comment.
I didn't notice that "Application" is translated as "응용 프로그램" in Visual Studio. and how about "응용 프로그램" instead?
There was a problem hiding this comment.
Then I agree with we should follow what the team has been already translated for now. LGTM.
@brettcannon
|
@LazyRichard @scari |
|
@DonJayamanne |
|
Once CI finishes I will merge this. |
|
Thanks @LazyRichard for the PR and everyone else for their input! This will be in our next release which should (hopefully) be sometime this week. |
No description provided.