Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SymbolKind.from and SymbolKind.to do not map SymbolKind.Field #21315

Closed
hoovercj opened this issue Feb 23, 2017 · 1 comment
Closed

SymbolKind.from and SymbolKind.to do not map SymbolKind.Field #21315

hoovercj opened this issue Feb 23, 2017 · 1 comment
Assignees
@bpasero @jrieken
Labels
bug Issue identified by VS Code Team member as probable bug editor-contrib Editor collection of extras verified Verification succeeded
Milestone
March 2017

Comments

@hoovercj
Copy link
Member

hoovercj commented Feb 23, 2017 •
edited
Loading

I noticed that SymbolKind.Field shows up using the expected icon in the suggestion widget but not in the quickoutline widget.

I see that quickopen.css defines the field icon for high contrast themes and shares a mapping with variable icons, but this same mapping isn't done elsewhere in the css.

Further, even if the CSS mapping is changed, in modes.ts SymbolKind.from and SymbolKind.to do not map SymbolKind.Field and the switch statement falls through to the default SymbolKind.Property, so a property icon would be used.
@hoovercj hoovercj mentioned this issue Feb 23, 2017
Merged
@alexdima alexdima assigned jrieken and bpasero and unassigned alexdima Feb 23, 2017
@bpasero bpasero added this to the March 2017 milestone Feb 24, 2017
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug editor-contrib Editor collection of extras labels Feb 24, 2017
@bpasero
Copy link
Member

bpasero commented Feb 28, 2017

Via #21318

@bpasero bpasero closed this as completed Feb 28, 2017
@roblourens roblourens added the verified Verification succeeded label Mar 30, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug editor-contrib Editor collection of extras verified Verification succeeded
Projects
None yet
Milestone
March 2017
Development

No branches or pull requests
5 participants
@roblourens @bpasero @jrieken @hoovercj @alexdima