Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CompletionItemKind.Method #10225

Merged
merged 1 commit into from
Aug 11, 2016
Merged

Conversation

sandyarmstrong
Copy link
Member

Previously, if a registered completion provider returned items with
CompletionItemKind.Method, they would display in the list as properties,
due to not being converted to the corresponding SuggestionType.

Previously, if a registered completion provider returned items with
CompletionItemKind.Method, they would display in the list as properties,
due to not being converted to the corresponding SuggestionType.
@msftclas
Copy link

msftclas commented Aug 5, 2016

Hi @sandyarmstrong, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Sandy Armstrong). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@sandyarmstrong
Copy link
Member Author

sandyarmstrong commented Aug 5, 2016

I was thinking of doing the same in MyCompletionItem.convertKind (for case PConst.Kind.memberFunction), but I'm not as familiar with that area of the code.

@jrieken jrieken added this to the August 2016 milestone Aug 8, 2016
@jrieken
Copy link
Member

jrieken commented Aug 11, 2016

LGTM

@jrieken jrieken merged commit 8236700 into microsoft:master Aug 11, 2016
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants