Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sodium mod with either 1.19.2/1.19.3 tis-3d causes display module placed on casing to become transparent #1567 #171

Closed
ComputerJock opened this issue Jan 7, 2023 · 2 comments

Comments

@ComputerJock
Copy link

Placing a display module on a casing causes both to become transparent. This happens for both 1.19.2 and 1.19.3 TIS-3D when the Sodium mod is also enabled.

sodium-fabric-mc1.19.2-0.4.4+build.18.jar
tis3d-MC1.19.2-fabric-1.7.1+b86ec05.jar

The Sodium mod has a million options so perhaps one of them affects this bug.

Reproduction Steps
Run either tis-3d versions for 1.19.2 or 1.19.3 with the sodium mod enabled. Place a display module on a casing block.

Java version
Java 17 as shipped by Mojang

CPU
Intel core i7

GPU
AMD Radeon HD 6900 Series

Additional information
I ran with only tis-3d & enabled/disabled sodium
I also ran with the entire suite of mods I use and enabled/disabled sodium

With sodium
No sodium

@Shazuli
Copy link

Shazuli commented Jan 8, 2023

I might add installing Indium, which is required for a lot of mods' special rendering, causes a crash.

@fnuecke
Copy link
Member

fnuecke commented Jan 8, 2023

From what I can tell, Sodium completely replaces Minecrafts regular chunk rendering pipeline. Which also means they disable Fabric's custom model baking hooks (i.e. the FabricBakedModel interface). And they don't re-implement them in their pipeline. So they call into a custom baked model using the regular BakedMode.getQuads method, instead of Fabric's FabricBakedModel.emitBlockQuads. Which cannot work (model needs the extra context provided by the Fabric version).

Guess I'll disable custom baked models (and with them the facade module) when Sodium is present.

fnuecke added a commit that referenced this issue Jan 8, 2023
It completely replaces the render pipeline but does not re-implement FabricBakedModel facilities, so these cannot work.
Means we also have to disable the facade module. It gets hidden in the creative tab and in REI via a plugin.
See #171.
fnuecke added a commit that referenced this issue Jan 8, 2023
It completely replaces the render pipeline but does not re-implement FabricBakedModel facilities, so these cannot work.
Means we also have to disable the facade module. It gets hidden in the creative tab and in REI via a plugin.
See #171.
fnuecke added a commit that referenced this issue Jan 8, 2023
It completely replaces the render pipeline but does not re-implement FabricBakedModel facilities, so these cannot work.
Means we also have to disable the facade module. It gets hidden in the creative tab and in REI via a plugin.
See #171.
fnuecke added a commit that referenced this issue Jan 8, 2023
It completely replaces the render pipeline but does not re-implement FabricBakedModel facilities, so these cannot work.
Means we also have to disable the facade module. It gets hidden in the creative tab and in REI via a plugin.
See #171.
@fnuecke fnuecke closed this as completed Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants