Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[X64] [xtqqczze] Use isinst in System.Data.Common.ObjectStorage:Set #182

Open
MihuBot opened this issue Sep 15, 2023 · 1 comment
Open

Comments

@MihuBot
Copy link
Owner

MihuBot commented Sep 15, 2023

Build completed in 1 hour 11 minutes.
dotnet/runtime#91945

CoreLib diffs

Found 1 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 6605240
Total bytes of diff: 6605240
Total bytes of delta: 0 (0.00 % of base)


0 total files with Code Size differences (0 improved, 0 regressed), 1 unchanged.

0 total methods with Code Size differences (0 improved, 0 regressed), 52942 unchanged.

--------------------------------------------------------------------------------

Frameworks diffs

Diffs
Found 259 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 37877682
Total bytes of diff: 37877226
Total bytes of delta: -456 (-0.00 % of base)
Total relative delta: Infinity
    diff is an improvement.
    relative diff is a regression.


Total byte diff includes -167 bytes from reconciling methods
	Base had    1 unique methods,      167 unique bytes
	Diff had    0 unique methods,        0 unique bytes

Top file improvements (bytes):
        -456 : System.Data.Common.dasm (-0.03 % of base)

1 total files with Code Size differences (1 improved, 0 regressed), 255 unchanged.

Top method regressions (bytes):
         167 (Infinity of base) : System.Net.Sockets.dasm - System.Net.Sockets.SocketAsyncEngine:TryRegisterSocket(long,System.Net.Sockets.SocketAsyncContext,byref,byref):ubyte (FullOpts)

Top method improvements (bytes):
        -456 (-32.50 % of base) : System.Data.Common.dasm - System.Data.Common.ObjectStorage:Set(int,System.Object):this (FullOpts)
        -167 (-100.00 % of base) : System.Net.Sockets.dasm - 

Top method regressions (percentages):
         167 (Infinity of base) : System.Net.Sockets.dasm - System.Net.Sockets.SocketAsyncEngine:TryRegisterSocket(long,System.Net.Sockets.SocketAsyncContext,byref,byref):ubyte (FullOpts)

Top method improvements (percentages):
        -167 (-100.00 % of base) : System.Net.Sockets.dasm - 
        -456 (-32.50 % of base) : System.Data.Common.dasm - System.Data.Common.ObjectStorage:Set(int,System.Object):this (FullOpts)

3 total methods with Code Size differences (2 improved, 1 regressed), 232459 unchanged.

--------------------------------------------------------------------------------

Artifacts:

@MihuBot
Copy link
Owner Author

MihuBot commented Sep 15, 2023

@xtqqczze

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant