Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do you have a comparison to CDVAE? #2

Closed
sgbaird opened this issue Jun 24, 2022 · 2 comments
Closed

Do you have a comparison to CDVAE? #2

sgbaird opened this issue Jun 24, 2022 · 2 comments

Comments

@sgbaird
Copy link

sgbaird commented Jun 24, 2022

I noticed you compared results to FTCP. Do you have comparison results for CDVAE? I understand this might be less feasible for the 500k generation based on the longer time it takes to generate CDVAE samples.

@usccolumbia
Copy link
Collaborator

" I understand this might be less feasible for the 500k generation based on the longer time it takes to generate CDVAE samples". Yes you said it.

Yes. We just finished the comparison on a smaller scale. The major finding is that CDVAE is not good at generating high-symmetry crystal structures. We generated 1100 structures using CDVAE. 860 are pymatgen readable structures. Out of the top 10 space groups with most samples, 97.8% 773/790 sampleshave very low space group ID numbers (<=25). This is a serious issue as most stable structures tend to have high symmetry.

@sgbaird
Copy link
Author

sgbaird commented Nov 6, 2022

@usccolumbia excellent, thanks! That's great info. Generation of low-symmetry structures without explicitly enforcing it seems to be a bane sparks-baird/xtal2png#79.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants