Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The link of missing line doesn't work properly with Jest option --changedSince #89

Open
vhoang1102 opened this issue Jun 6, 2024 · 2 comments

Comments

@vhoang1102
Copy link

vhoang1102 commented Jun 6, 2024

Hi, hope you're doing well! I'm using your action and it works perfectly. But I have around 10k unit tests so I just want to run some of them that relate to changed file in the PR. So I use the jest option --changedSince=origin/master in the running command. Then when I click on the link of missing line, it seems to be lacking of coveragePathPrefix. This is an example link: https://git.abc.net/xyz/mno/blob/a1a3c28b2b5642925e6f201ecac5489341408e0b/responses.ts#L33 and it shows 404 not found.

Please note it works well if I don't use the option --changedSince=origin/master. Could you please help? Did I miss any configuration? I did try adding coverage-path-prefix: src/ but it doesn't help, it just includes /src to the link but my file is located at src/clients/abc/responses.ts

@MishaKav
Copy link
Owner

MishaKav commented Jun 9, 2024

I will try to reproduce your case with --changedSince=origin/master and let you know.

@vhoang1102
Copy link
Author

Beside of that, if I use the Jest option --findRelatedTests or --changedSince, jest coverage report All File (in the attached picture) seems to be un-helpful, can we have an option to disable it in the report.
Screenshot 2024-06-10 at 10 56 12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants